RSDK-12160 Remove audio input component type #5616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to test
Contributor
|
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
hexbabe
approved these changes
Jan 7, 2026
Member
hexbabe
left a comment
hexbabe
left a comment
There was a problem hiding this comment.
LGTM! Removing opus sounds great
gostream/stream.go
Outdated
| if config.VideoEncoderFactory == nil && config.AudioEncoderFactory == nil { | ||
| return nil, errors.New("at least one audio or video encoder factory must be set") | ||
| if config.VideoEncoderFactory == nil { | ||
| return nil, errors.New("at least one video encoder factory must be set") |
Contributor
There was a problem hiding this comment.
Can there be multiple factories?
Member
Author
There was a problem hiding this comment.
I don't know much about gostream but from this error message I assume yes, @seanavery or @hexbabe may know more.
Member
There was a problem hiding this comment.
IIUC, we should probably change this error message to "a video encoder factory must be set"
The original error is basically saying "at least one of audio or video encoder factory must be set"
Member
Author
There was a problem hiding this comment.
got it thanks for clarifying, changing the error message
Contributor
pun intended? :) |
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes audioinput type, replacing it with audioin type in all instances. Also removing audio from stream server since it is no longer being used.